Action buttons do not describe element being controlled
Opened this issue · 4 comments
Our accessibility audit would like to see our action buttons to have more descriptive labels that include what is being affected by the action. For example, "Remove" should read "Remove 'Title' element". This would mean a lot of strings would need translation updates. I tried looking into aria roles that would fit the bill, but the closest I could find was aria-controls, which seems to have really poor support across screen readers. How do we want to address this, if at all?
Where specifically is this being flagged?
We recently did work along these lines for the main edit forms... my recollection is that it used kind of a chain (not actually a chain but just multiple values) of aria-labelledby to build up more complex accessible labels from the existing labels. Or I should say we accepted a PR that did this, that is.
We also sometimes do things like using fieldsets or aria-group to provide context to repeated controls like that.
Ah, maybe this is a pattern I forgot about and it's not been implemented across the plugins. I'm looking at issue 72 for Contribution.
Specific to contribution, you might not need lots of strings for this, so explicit aria-labels that use a "remove element %s" type pattern might just be the best move there.