onekey-sec/unblob

Unblob wheel doesn't contain the rust binding

vlaci opened this issue · 1 comments

vlaci commented

The release build differs from how we build it for the docker image:

run: UNBLOB_BUILD_RUST_EXTENSION=1 poetry build --format wheel

- run: poetry publish --build

I'd adwise to build wheels for all main branch merges and store1 them as artifacts. Tests should also run against the wheel built that way. The release should just fetch2 the artifact matching the tag and publish it. That way we ensure that the wheel is tested and works properly.

Also, the wheel contains the rust source code.

Footnotes

  1. Example from pyperscan

  2. Example from pyperscan

vlaci commented

Fixed via #571