onekey-sec/unblob

No timeout defined for Command Extractor

qkaiser opened this issue · 0 comments

The framework calls external extractors without setting an explicit execution timeout. If an external extractors goes haywire (e.g. debugfs getting into an endless loop), unblob may never finish.

After an internal discussion, we decided to set a timeout value that is high enough not to block long running execution such as extraction of large disk images, but small enough to make sure unblob finish its execution at some point.

We agreed to a 12 hours timeout 🤓