Release 1.4.0 is broken with Docker: missing parentheses in call to `print`

Question

israel-tk opened this issue 6 years ago · 6 comments

A recent commit introduced some lines with print "something" like https://github.com/onelogin/onelogin-python-aws-assume-role/blob/master/src/onelogin/aws-assume-role/aws-assume-role.py#L215 which are not allowed in Python 3. Simply change it to print("something").

Done

Answer 1 · 2018-09-12T07:44:57.000Z

BTW I suggest some CI to check that the code is compatible with Python 2 and 3 on every build. :)

Answer 2 · 2018-09-12T08:37:53.000Z

Thanks for the PR, you are right.

Answer 3 · 2018-09-12T08:38:46.000Z

Can we push a release 1.4.1?

Answer 4 · 2018-09-12T08:42:32.000Z

@israel-tk you are right now the most active dev using the script, do you have any feedback to share?

Answer 5 · 2018-10-01T08:45:36.000Z

@pitbulk not right now, but will contact you whenever I have some! :)