"Open all in tabs" no longer working in latest Waterfox

Question

"Open all in tabs" no longer working in latest Waterfox

Closed this issue 7 months ago · 10 comments

Since the last Waterfox update 2 weeks the option to "Open all in tabs" from a folder of bookmarks no longer works. Someone in the Waterfox subreddit says using the middle mouse button doesn't work for it any more either.

If we disable TMP then "Open all in tabs" works again. For now I'm just dragging the folder to the tab bar, but it would be great if this could get fixed. Not sure who broke it though, TMP or Waterfox.

Answer 1 · 2024-03-09T17:06:04.000Z

try to use the latest Development Build

download tab_mix_plus-dev-build.xpi

Answer 2 · 2024-03-09T17:10:58.000Z

Unfortunately that didn't help, Open All in Tabs still doesn't work. Thanks for trying though ☺️

Answer 3 · 2024-03-09T17:28:11.000Z

report if you get any messages in the Browser Console

Answer 4 · 2024-03-09T17:33:03.000Z

Does this help? Or do I need to do anything else?
Hmm, it won't let me add the screenshot so I uploaded it here.

Answer 5 · 2024-03-09T17:36:23.000Z

19:33:20.938 Uncaught ReferenceError: originalOpenTabset is not defined
    <anonymous> chrome://tabmix-resource/content/Places.jsm line 90 > eval:3
    openMultipleLinksInTabs resource:///modules/PlacesUIUtils.sys.mjs:1057
    oncommand chrome://browser/content/browser.xhtml:1
[Places.jsm line 90 > eval:3:7](chrome://tabmix-resource/content/Places.jsm%20line%2090%20%3E%20eval)
19:33:26.085 This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”.
[browser.xhtml](view-source:chrome://browser/content/browser.xhtml)
19:33:26.357 TypeError: window.PrivateBrowsingUtils is undefined
[WaterfoxGlue.sys.mjs:234:15](resource:///modules/WaterfoxGlue.sys.mjs)

I will work on this tomorrow

Answer 6 · 2024-03-09T17:39:45.000Z

I have NO idea what all that code means, but thank you SO MUCH for looking into this 💙

Answer 7 · 2024-03-09T17:51:15.000Z

Waterfox made changed to the code 2 weeks ago

  overridePlacesUIUtils() {
    // Save a reference to the original function
    const originalOpenTabset = PlacesUIUtils.openTabset;

    // Redefine the function
    PlacesUIUtils.openTabset = function(aEvent, aWindow, aTabs, loadInBackground) {
      // Call the original function with the modified arguments
      return originalOpenTabset.call(this, aEvent, aWindow, aTabs, loadInBackground, aEvent.userContextId || 0);
    };

When Tab Mix Plus try to update PlacesUIUtils.openTabset the function can not find the reference to originalOpenTabset

Answer 8 · 2024-03-09T18:00:30.000Z

Yea I knew they changed something, but I have no idea what. As long as it's fixable I'm sure you'll find a solution ☺️

Answer 9 · 2024-03-09T20:05:18.000Z

Download and install this NEW test build

Answer 10 · 2024-03-09T20:16:58.000Z

Yesssss, you did it - Open All in Tabs is working again!

Thank you soooo much for the quick fix! 😍