Add FCLCrypto to default deployed contracts

Question

Add FCLCrypto to default deployed contracts

Closed this issue 2 years ago · 7 comments

FCLCrypto contract should be deployed along with default contracts on emulator start

Dev wallet relies on FCLCrypto Contract and currently needs to be manually deployed to avoid an error
when authenticating with FCL ^1.0.0

If added as one of the default contracts on emulator start, this step and error can be avoided.

https://github.com/onflow/fcl-contracts/tree/main/contracts

Answer 1 · 2022-07-14T10:53:08.000Z

@gregsantos sorry for late reply, should we prioritize this in this sprint?

Answer 2 · 2022-07-14T14:44:02.000Z

No problem @sideninja
Yea, i think it is a good idea to prioritize this sprint as it will address a prominent issue with local development.

Answer 3 · 2022-07-14T18:13:30.000Z

why this contract exists btw ? it seems like it is just one function.

Answer 4 · 2022-07-15T07:52:33.000Z

@gregsantos I'm finishing up this task, but I would need the https://github.com/onflow/fcl-contracts to become public repo.

Answer 5 · 2022-07-15T17:30:02.000Z

@psiemens may need to open as code owner

@bluesign This contract is used in verifying signatures (user, and account-proof)

Answer 6 · 2022-07-16T06:23:44.000Z

I understand @gregsantos but as I mentioned earlier[0], especially emulator has so many unnecessary contracts.

To run a single function, deploying a new contract, seems little unnecessary to me. Is there a specific reason for this to be a contract, instead of Function in the script ?

[0] #170

Answer 7 · 2022-07-21T15:01:37.000Z

@bluesign Thanks Deniz, your thoughts on emulator contracts makes sense.
We created the FCLCrypto contract when the cadence Crypto lib was removed and to help with transition to account-proof v2. We may switch back to using a script, making this unnecessary soon. For now it might be better to deploy the contract along with others in the dev-wallet. Closing this in favor of onflow/fcl-dev-wallet#136