onflow/flow-emulator

Crashes galore

Closed this issue · 5 comments

justjoolz commented

Problem

Seeing a lot of uncaught crashes in the latest Version: v0.39.1

Language server isn't catching some errors and they're causing trouble for the emulator...
"Expected casting" error was hidden way below verbose golang error logs and not caught by language server in vscode either

Other runtime errors also not being caught:

  • calling verify in cadence with an invalid message/signature pair causes emulator to crash (but doesn't ask if you want to send crash report ie. just dumps verbose golang logs but does not fully crashes)....
sideninja commented

Thank you for reporting this to us!

Language server isn't catching some errors and they're causing trouble for the emulator...
"Expected casting" error was hidden way below verbose golang error logs and not caught by language server in vscode either

Can you let me know how we can reproduce this?

calling verify in cadence with an invalid message/signature pair causes emulator to crash (but doesn't ask if you want to send crash report ie. just dumps verbose golang logs but does not fully crashes)....

Interesting, will look into it and try catch those.

  • 👍1
sideninja commented

That's interesting. I will take a look into this as soon as I can, just pinging @turbolent meanwhile as well. Thank you for the report.

turbolent commented

Please do not report crashers publicly and follow https://www.onflow.org/flow-responsible-disclosure instead. Thank you!

  • 👍1
turbolent commented

@justjoolz Thank you for reporting the issues, we are going to look into them. As a precaution, we've deleted the comments here.

  • 👍1
bluesign commented

I think this is fixed and can be closed.

Stack trace is from Cadence error message also I guess. So it is not from emulator.

  • 👍2