Named parameters are not used for known functionalities

[sisyphusSmiling]

Description

In contracts/HybridCustody.cdc:801, the display metadata view is stored in a dictionary with a hardcoded key “display”. Since the field and the functionality is already known, hardcoding the parameter can be avoided.

Recommendation

We recommend using dedicated fields for any known variables.

Discussion

This was discussed while exploring metadata views and resolution patterns for this contract. We'll want to decide if a display field should be included in ChildAccount the way it is in ProxyAccount.

[sisyphusSmiling]

Does this occur anywhere other than the display noted in the recommendation and addressed in #89? If not, I think we're good to close this

[sisyphusSmiling]

Closing as this has been addressed in #89