onyx-platform/onyx-kafka

NPE caused by missing either :onyx/n-peers or :onyx/max-peers

kennyjwilli opened this issue · 1 comments

kennyjwilli commented

I think the docs on onyx-kafka should mention which keys are required. I just ran into a NPE due to not having set :onyx/n-peers or :onyx/max-peers caused by:

onyx-kafka/src/onyx/plugin/kafka.clj

Line 80 in 86f4223

n-peers-less-eq-n-partitions (and n-peers (<= n-peers n-partitions))]

It would've been helpful to have known I need to specify one of those.

lbradstreet commented

Fixed in master. The problem was in the condition that checked whether min-peers = max-peers, as both were nil, and it was allowed rather than specifying that one must be set.