open-dis/open-dis-java

Difference in comments to implementation

Jonoo97 opened this issue · 1 comments

Jonoo97 commented

Comment says Gets the Euler Theta value (in radians) from position and Tait-Brayn yaw and roll angles but implementation uses pitch not roll public static double getThetaFromTaitBryanAngles(double lat, double lon, double yaw, double pitch). This is the same for getPsiFromTaitBryanAngles.

open-dis-java/src/main/java/edu/nps/moves/disutil/EulerConversions.java

Line 126 in d3c2b19

* Gets the Euler Theta value (in radians) from position and Tait-Brayn yaw and roll angles

leif81 commented

Thanks @Jonoo97 ! You're welcome to submit a PR if you like.