ElectronicEmissionsPdu dis7 Support

Question

ElectronicEmissionsPdu dis7 Support

lcowan94 opened this issue 4 years ago · 4 comments

Hi, I was wondering if the ElectronicEmissionPdu in dis7 will be fully supported?
I am in need of getting the beam status from the ElectronicEmissionPdu as in section 7.6.2.2.f.5.ix

Answer 1 · 2020-11-13T02:17:12.000Z

Hi @lcowan94

Pull requests are welcome. Would you be interested in submitting a PR for this change?

And could you share a sample pdu to be used here in a junit test to confirm the implementation?

Answer 2 · 2020-11-17T09:10:16.000Z

Hi, I've got an update with some unit tests for you. How do I submit the pull request?

Answer 3 · 2020-11-19T01:56:02.000Z

Terrific.
There's some good info here on creating pull requests.
https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/proposing-changes-to-your-work-with-pull-requests

Answer 4 · 2020-11-20T13:59:10.000Z

Thanks again @lcowan94 for the contribution.

I will probably cut a v5.1 release since your change is significant enough. Let me know if that'd be useful for you.