open-feature/java-sdk

Maven dependency for Jakarta and Java 17

Closed this issue · 5 comments

Exnadella commented

Dear Team,

We're requesting the release of the dependency for Jakarta and Java 17, as we're transitioning most of our stack from Java 8 to Java 17, which necessitates migrating from Javax to Jakarta for compatibility. Additionally, could we consider using Spring Boot 3.2.0 for demonstration purposes?

Kavindu-Dodan commented

@Exnadella thank you for raising concern over the Javax annotation. I can confirm that OpenFeature Java SDK uses javax.annotation.Nullable.

Could you please share any issues that you faced during the migration to Java 17 ? For example, do you have checks for Javax ? Otherwise, if you intend to avoid dependency on jsr305, then you may do this by adding an exclusion rule to OF Java SDK.

For example, for maven

        <dependency>
            <groupId>dev.openfeature</groupId>
            <artifactId>sdk</artifactId>
            <version>1.7.6</version>
            <exclusions>
                <exclusion>
                    <groupId>com.google.code.findbugs</groupId>
                    <artifactId>jsr305</artifactId>
                </exclusion>
            </exclusions>
        </dependency>

A missing annotation should not fail your build or application.

toddbaert commented

I think we should remove all @Nullable usage from the SDK. It's not doing that much for us, I don't think it's worth the trouble since it's non-standard.

  • 👍1
Kavindu-Dodan commented

@toddbaert yeah, that's an option and a quick solution for this

toddbaert commented

@DBlanchard88 is working on this.

toddbaert commented

@Exnadella We have removed all these annotations. The next release will not contain them.

  • 🎉1