open-feature/open-feature-operator

v1beta migration missing a diff?

agardnerIT opened this issue · 1 comments

agardnerIT commented

Reading https://github.com/open-feature/open-feature-operator/blob/main/docs/v1beta_migration.md

I think the diff example needs to be updated. Currently:

- apiVersion: core.openfeature.dev/v1alpha3
+ apiVersion: core.openfeature.dev/v1beta1
kind: FeatureFlagConfiguration
metadata:
  name: end-to-end
  labels:
    app: open-feature-demo
spec:
-  featureFlagSpec:
+  flagSpec 
    flags:
      new-welcome-message:
        state: ENABLED
        variants:
          'on': true
          'off': false
        defaultVariant: 'off'

But I believe:

- apiVersion: core.openfeature.dev/v1alpha3
+ apiVersion: core.openfeature.dev/v1beta1
- kind: FeatureFlagConfiguration
+ kind: FeatureFlag
metadata:
  name: end-to-end
  labels:
    app: open-feature-demo
spec:
-  featureFlagSpec:
+  flagSpec 
    flags:
      new-welcome-message:
        state: ENABLED
        variants:
          'on': true
          'off': false
        defaultVariant: 'off'
Kavindu-Dodan commented

This isssue was addresed with the PR - #573

Updated documentation can be found here - https://github.com/open-feature/open-feature-operator/blob/main/docs/v1beta_migration.md

  • ❤️1