open-policy-agent/opa

CI: Upgrade to `actions/upload-artifact@v4` and `actions/download-artifact@v4`

Closed this issue · 5 comments

sean-r-williams commented

What is the underlying problem you're trying to solve?

GitHub Actions is currently using actions/upload-artifact@v3, which has known issues (see actions/upload-artifact#443). Looking at PRs like #6636, you can see several failed checks due to 503s from uploading the artifact.

Describe the ideal solution

GitHub has released v4 of their Artifacts actions last December. According to a GitHub dev (see actions/upload-artifact#443 (comment)), these are powered by an entirely new backend that should resolve this issue.

Describe a "Good Enough" solution

If something is explicitly chaining OPA to v3 of the Artifacts actions, providing a mechanism for PR authors to trigger a rerun would be appreciated.

Additional Context

sean-r-williams commented

FWICT, the pull-request workflow should be directly compatible with v4.

For post-tag and post-merge, however, the lack of unique artifact names will conflict with the new unique artifact label requirements.

  • 👀1
anderseknert commented

providing a mechanism for PR authors to trigger a rerun would be appreciated

That would be useful for sure. If anyone knows of a way to accomplish that, let us know!

ashutosh-narkar commented

@sean-r-williams if you'd like to submit a fix for the pull-request workflow that would be great. We can look into doing the update for the others as well.

stale commented

This issue has been automatically marked as inactive because it has not had any activity in the last 30 days. Although currently inactive, the issue could still be considered and actively worked on in the future. More details about the use-case this issue attempts to address, the value provided by completing it or possible solutions to resolve it would help to prioritize the issue.

srenatus commented

I think this is done.