Tests on the main branch fail

Question

Tests on the main branch fail

Closed this issue a month ago · 3 comments

nikpivkin commented a month ago

Short description

branch: main
commit: 3954ba0c80b5f00a8b30caff7b5ae600d551df1f
opa: 0.63.0
go: go1.22.2 darwin/arm64
os: MacOS

Steps To Reproduce

git checkout main
make test

Expected behavior

Tests will be completed successfully

Additional context

--- FAIL: TestBenchMainWithBundleRegoVersion (67.37s)
    --- FAIL: TestBenchMainWithBundleRegoVersion/bundle_dir,_v0_bundle,_e2e (0.45s)
        bench_test.go:1001: Unexpected return code 1, expected 0
{"level":"error","msg":"Bundle activation failed: 1 error occurred: ~0/policy2.rego:3: rego_parse_error: unexpected identifier token: expected \\n or ; or }\n\t42 in p\n\t   ^","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 1 error occurred: ~0/policy2.rego:3: rego_parse_error: unexpected identifier token: expected \\n or ; or }\n\t42 in p\n\t   ^","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 3 errors occurred:\n~0/policy.rego:2: rego_parse_error: var cannot be used for rule name\n~0/policy.rego:2: rego_parse_error: var cannot be used for rule name\n~0/policy.rego:2: rego_parse_error: string cannot be used for rule name","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 1 error occurred: ~0/policy2.rego:3: rego_parse_error: unexpected identifier token: expected \\n or ; or }\n\t42 in p\n\t   ^","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 1 error occurred: ~0/policy2.rego:3: rego_parse_error: unexpected identifier token: expected \\n or ; or }\n\t42 in p\n\t   ^","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 2 errors occurred:\n~0/policy.rego:2: rego_parse_error: `if` keyword is required before rule body\n~0/policy.rego:2: rego_parse_error: `contains` keyword is required for partial set rules","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 2 errors occurred:\n~0/policy1.rego:2: rego_parse_error: `if` keyword is required before rule body\n~0/policy1.rego:2: rego_parse_error: `contains` keyword is required for partial set rules","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 2 errors occurred:\n~0/policy1.rego:2: rego_parse_error: `if` keyword is required before rule body\n~0/policy1.rego:2: rego_parse_error: `contains` keyword is required for partial set rules","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 2 errors occurred:\n~0/policy1.rego:2: rego_parse_error: `if` keyword is required before rule body\n~0/policy1.rego:2: rego_parse_error: `contains` keyword is required for partial set rules","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 2 errors occurred:\n~0/policy1.rego:2: rego_parse_error: `if` keyword is required before rule body\n~0/policy1.rego:2: rego_parse_error: `contains` keyword is required for partial set rules","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 1 error occurred: ~0/policy2.rego:3: rego_parse_error: unexpected identifier token: expected \\n or ; or }\n\t42 in p\n\t   ^","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 1 error occurred: ~0/policy2.rego:3: rego_parse_error: unexpected identifier token: expected \\n or ; or }\n\t42 in p\n\t   ^","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 3 errors occurred:\n~0/policy.rego:2: rego_parse_error: var cannot be used for rule name\n~0/policy.rego:2: rego_parse_error: var cannot be used for rule name\n~0/policy.rego:2: rego_parse_error: string cannot be used for rule name","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 1 error occurred: ~0/policy2.rego:3: rego_parse_error: unexpected identifier token: expected \\n or ; or }\n\t42 in p\n\t   ^","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 1 error occurred: ~0/policy2.rego:3: rego_parse_error: unexpected identifier token: expected \\n or ; or }\n\t42 in p\n\t   ^","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 2 errors occurred:\n~0/policy.rego:2: rego_parse_error: `if` keyword is required before rule body\n~0/policy.rego:2: rego_parse_error: `contains` keyword is required for partial set rules","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 2 errors occurred:\n~0/policy1.rego:2: rego_parse_error: `if` keyword is required before rule body\n~0/policy1.rego:2: rego_parse_error: `contains` keyword is required for partial set rules","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 2 errors occurred:\n~0/policy1.rego:2: rego_parse_error: `if` keyword is required before rule body\n~0/policy1.rego:2: rego_parse_error: `contains` keyword is required for partial set rules","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 2 errors occurred:\n~0/policy1.rego:2: rego_parse_error: `if` keyword is required before rule body\n~0/policy1.rego:2: rego_parse_error: `contains` keyword is required for partial set rules","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 2 errors occurred:\n~0/policy1.rego:2: rego_parse_error: `if` keyword is required before rule body\n~0/policy1.rego:2: rego_parse_error: `contains` keyword is required for partial set rules","name":"~0","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}
{"level":"error","msg":"Bundle activation failed: 1 error occurred: /example.rego:4: rego_type_error: undefined function bits.sand","name":"test","plugin":"bundle","time":"2024-04-19T22:11:50+07:00"}

Answer 1 · 2024-04-19T19:38:35.000Z

Hmm..I am not able to repro this. There could be something going on in your local setup. My version is go1.21.0 darwin/amd64 but even with the updated Go version, I wouldn't expect this test failure.

Answer 2 · 2024-04-20T05:07:51.000Z

Strangely, clearing the cache helped. But I am facing another error while running wasm tests, could you please help?

docker run --name opa-wasm-testgen-container -u 501:20 -v /Users/nikita/projects/opa/.go/bin:/go/bin:Z -v /Users/nikita/projects/opa:/src:z -v /Users/nikita/projects/opa/test/wasm/assets:/assets:Z -e GOCACHE=/src/.go/cache -w /src golang:1.22.2 sh -c 'make wasm-rego-testgen-install \
                && wasm-rego-testgen \
                --input-dir=/assets \
                --runner=/src/test/wasm/assets/test.js \
                --output=/src/.go/cache/testcases.tar.gz'
fatal: detected dubious ownership in repository at '/src'
To add an exception for this directory, call:

        git config --global --add safe.directory /src
CGO_ENABLED=1 GOFLAGS=""-buildmode=exe"" go install ./test/wasm/cmd/wasm-rego-testgen
error obtaining VCS status: exit status 128
        Use -buildvcs=false to disable VCS stamping.
make: *** [Makefile:236: wasm-rego-testgen-install] Error 1

Answer 3 · 2024-04-22T19:46:35.000Z

This PR should address it.