open-simh/simh

PDP11 - Disassembly of ASH instruction

outofmbufs opened this issue · 6 comments

context

PDP-11 simulator Open SIMH V4.1-0 Current        git commit id: 4e159a04
sim> d 10000 072002
sim> e -m 10000
10000:	ASH R2,R0
sim> d 10000 072102
sim> e -m 10000
10000:	072102

ASH seems to only disassemble if the R (072RSS) is zero.

simh> SHOW VERSION

PDP-11 simulator Open SIMH V4.1-0 Current
    Simulator Framework Capabilities:
        32b data
        32b addresses
        Threaded Ethernet Packet transports:PCAP:NAT:UDP
        Idle/Throttling support is available
        Virtual Hard Disk (VHD) support
        RAW disk and CD/DVD ROM support
        Asynchronous I/O support (Lock free asynchronous event queue)
        Asynchronous Clock support
        FrontPanel API Version 12
    Host Platform:
        Compiler: GCC Apple LLVM 12.0.5 (clang-1205.0.22.9)
        Simulator Compiled as C arch: x64 (Release Build) on Feb 25 2023 at 17:57:07
        Build Tool: simh-makefile
        Memory Access: Little Endian
        Memory Pointer Size: 64 bits
        Large File (>2GB) support
        SDL Video support: No Video Support
        No RegEx support for EXPECT commands
        OS clock resolution: 1ms
        Time taken by msleep(1): 1ms
        Ethernet packet info: libpcap version 1.10.1
        OS: Darwin NWAir.local 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:28:31 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T8112 x86_64
        Processor Name: Apple M2
        tar tool: bsdtar 3.5.3 - libarchive 3.5.3 zlib/1.2.12 liblzma/5.0.5 bz2lib/1.0.8
        curl tool: curl 8.1.2 (x86_64-apple-darwin23.0) libcurl/8.1.2 (SecureTransport) LibreSSL/3.3.6 zlib/1.2.12 nghttp2/1.55.1
        git commit id: 4e159a04
        git commit time: 2023-01-04T13:22:12-0700

And some further detail:

sim> d -m 10000 ash r2,r1
sim> e -m 10000
10000:    072102

@rms47 should look at this....

ASHC too

sim> d 10000 ashc r2,r3
sim> e -m 10000
10000:	073302
sim> d 10000 ashc r2,r0
sim> e -m 10000
10000:	ASHC R2,R0

I just created PR #331 to fix this.

rms47 commented

Well, that's embarrassing. Paul's PR is correct. I've updated the V3 source pool.

Thanks Bob. I merged the PR.

The fix was incomplete (because of the previously wrongly committed piece), discussed in #331