open-source-labs/Reactime

False parsing of ArrayPattern

anilanar opened this issue · 4 comments

https://github.com/open-source-labs/reactime/blob/37ae68c5615f44a977fb08137adedf709b472353/src/backend/helpers.ts#L107-L114

The above code breaks for the following case:

const [, setState] = useFoo();

because hook.id.elements[0] is null with the above pattern match. hook.name will crash.

Hi @anilanar,

Thanks for bringing this to our attention, we are looking into it.

Could you possibly link to the repo where you're having this issue?

Thanks!

@rtviner I cannot. If const [, setState] = useFoo(); is not reproducable, feel free to close.

This should be easy to fix. See #261 for a fix for a similar issue in the same part of the code.

Already found a fix in a prior branch and merged in from a prior contributor see #261 thread