Delete stale branches. Delete chainRequest, staging,... from open-source-labs/Swell
8D-k opened this issue · 8 comments
Describe the bug
open-source-labs/Swell has stale branches.
If these branches do not have an active purpose, let's delete them.
Delete chainRequest, protocolfix, Amanda, sam/history, paul/ui-fixes, sam/render-html, update/version, and staging
https://github.com/open-source-labs/Swell/tree/chainRequest
https://github.com/open-source-labs/Swell/tree/protocolfix
https://github.com/open-source-labs/Swell/tree/Amanda
https://github.com/open-source-labs/Swell/tree/sam/history
https://github.com/open-source-labs/Swell/tree/paul/ui-fixes
https://github.com/open-source-labs/Swell/tree/sam/render-html
https://github.com/open-source-labs/Swell/tree/update/version
https://github.com/open-source-labs/Swell/tree/staging
To Reproduce
Expected behavior
Only keep active branches for development and release cycle purposes, such as dev and master
Actual behavior
chainRequest
Updated 2 years ago by addoasa
protocolfix
Updated 2 years ago by Amanda Flink
Amanda
Updated 2 years ago by Amanda Flink
sam/history
Updated 2 years ago by sam-parsons
paul/ui-fixes
Updated 2 years ago by Paul Rhee
sam/render-html
Updated 2 years ago by sam-parsons
update/version
Updated 2 years ago by prheee
staging
Updated 15 months ago by mjmiguel
Screenshots
Desktop (please complete the following information):
- OS: Any
- Browser: Any
- Version: Any
Additional context
Thank you!
@addoasa @aflinky @sam-parsons @prheee @mjmiguel
Are these still in use for release processes?
@cgefx @tedcraig @MajorLift
I see you are some of the most recent contributors. Do you know if these branches are still in use for anything?
no I can't imagine they are but whats to gain by deleting them?
no I can't imagine they are but whats to gain by deleting them?
Unnecessary code and branches, like any other, requires maintenance over time. Makes it harder to learn the Swell project, requiring extra understanding. Introduces extra navigation through GitHub to know the project.
The specific branches in question have no direct offense identified aside from being unnecessary. If unnecessary, then the branches appear potentially as a form of bloat or technical debt easily erased.
If the branches are still actively being pursued, then it is also materially interesting when opening new pull requests to be aware of their contents, such as the purpose of the long lived branches.
The files modified in these branches may introduce merge conflicts if pull requests are incoming for these branches to master or dev, for example.
What is to gain? Clarity. Saved time in development. Reduced complexity. Less apparent technical debt. Fewer concerns of merge conflict
Is there a loss of value from deleting these branches? What value is maintained by keeping these branches?
Is there a loss of value from deleting these branches? What value is maintained by keeping these branches?
My feeling is that stale branches offer a bit of history and perspective on the who/what/where/when of how the repo evolves over time. The fact that GitHub offers the feature to begin with supports this notion.
Also, I just went to a handful of other active repos varying from large too small and none of them are deleting stale branches. If the React, Gatsby, Electron, ect... maintainers allow stale branches going back 5+ years, thats good enough for me to want to keep them around.
If contributors want to delete their own stale branches maybe thats their right, but allowing current maintainers to delete history that they may or may not have participated in is to me a total loss and maybe even not fair to past and future contributors.
Happy to open a larger discussion if any contributors feel otherwise, but until then, the stale branches live on...
Hey all, it is our opinion that stale branches should be deleted. For historical reference of contributions we have the Pull Request history. Since the branches have been outdated via a few dozen version upgrades, we are going to delete them.
Apologies if this makes some people's contributions less visible, but in a fast-paced rapidly growing application environment, we don't want future devs to get lost in the Git history and filesystem.