Update App screens shots in readme

Question

Update App screens shots in readme

Closed this issue 3 months ago · 17 comments

therajanmaurya commented 4 months ago

Summary:

Summarize your issue in one sentence (what goes wrong, what did you expect to happen).

Steps to reproduce:

How can we reproduce the issue?

Expected behaviour:

What did you expect the app to do?

Observed behaviour:

What did you see instead? Describe your issue in detail here.

Device and Android version:

What make and model device (e.g., Samsung Galaxy S3) did you encounter this on? What Android
version (e.g., Android 4.0 Ice Cream Sandwich or Android 6.0 Marshmallow) are you running? Is it
the stock
version from the manufacturer or a custom ROM?

Screenshots:

Can be created by pressing the Volume Down and Power Button at the same time on Android 4.0 and higher.

Akshay2004-701 commented 3 months ago

ok, sure

Answer 1 · 2024-02-27T15:11:42.000Z

I would like to do this task, can I be assigned with it?

Answer 2 · 2024-02-29T09:04:17.000Z

@therajanmaurya can i work on this issue ?

Answer 3 · 2024-02-29T20:27:28.000Z

Hey @Akshay2004-701, as you commented first, so please directly make a PR and send the PR link in the Slack Channel.
Thanks!

Answer 4 · 2024-03-14T02:56:27.000Z

@Akshay2004-701 Can I go with this if you're okay with it?

Answer 5 · 2024-03-14T03:04:49.000Z

Thank you @Akshay2004-701 . @PratyushSingh07 Please assign this to me.

Answer 6 · 2024-03-14T03:58:40.000Z

Go ahead @Vikashgathala

Answer 7 · 2024-03-14T06:07:12.000Z

@PratyushSingh07 Do I need to add the screenshots of the same screens and in the same order as previous ones? I am unable to add beneficiaries so same activities with new UI isnt possible right now.

Answer 8 · 2024-03-14T06:09:57.000Z

In that case add UI of those screens that are visible

Answer 9 · 2024-03-14T07:03:43.000Z

@PratyushSingh07 Have a look at this. LGTM.

Answer 10 · 2024-03-14T07:22:24.000Z

Instead of loan account details we can show Help section. Moreover, I would prefer having something similar to the one used in Android client. Let me know if you can replicate that

Answer 11 · 2024-03-14T07:24:44.000Z

@PratyushSingh07 I'll do this by evening.

Answer 12 · 2024-03-14T07:25:30.000Z

Great, thanks

Answer 13 · 2024-03-14T08:10:23.000Z

@PratyushSingh07 Done.

Answer 14 · 2024-03-14T08:23:36.000Z

Lgtm @Vikashgathala . Can you just replace the current help section screenshot with the one in which we can have some of the answers as well. I mean can you expand a few of them . It would look better imo. Let me know if you think otherwise

Answer 15 · 2024-03-14T08:35:27.000Z

There is no UI separation between the help section's question and solution after expanding. I tried that but it looks like a single paragraph. This looks a little better and we have any ui improvements in help section in future, it would be better to update it in this. also, I have squashed the commits and its ready from my side until you find it mandatory to update the screenshots as you are recommending. Let me know what you think. @PratyushSingh07

Answer 16 · 2024-03-14T08:39:40.000Z

Lgtm , we can go ahead with this. Please open a PR. It seems that you have just pushed the changes to your fork and haven't actually opened the PR