openSUSE/rapidquilt

Broken permissions in `.pc` quilt directory

Opened this issue · 0 comments

rapidquilt-0.6.6+git0.166185f-kt.1.10.x86_64

I have a series that won't apply cleanly:

Applying 63527 patches using 16 threads...
Saving modified files...
Saving rejects to "include/linux/sched/task.h.rej"
Saving rejects to "kernel/fork.c.rej"
Saving quilt backup files (last 100)...
Saving rejects to "kernel/sched/core.c.rej"
Failed to save quilt backup file: ".pc/patches.suse/powerpc-bpf-Validate-branch-ranges.patch/arch/powerpc/net/bpf_jit_comp64.c"
  Permission denied (os error 13)
[ Tree: /tmp/k...s ]

ll .pc/patches.suse/powerpc-bpf-Validate-branch-ranges.patch/arch/powerpc/net/bpf_jit_comp64.c
-r--r--r-- 1 mkoutny mkoutny 31K Mar  1 13:45 .pc/patches.suse/powerpc-bpf-Validate-branch-ranges.patch/arch/powerpc/net/bpf_jit_comp64.c

I think the fix from 181d5b0 in save_backup_file together with our

    find $ORIG_DIR -type f | xargs chmod a-w,a+r                                                                                                                                                                                                                                  

in scripts/sequence-patch.sh won't play along.

I think the change in save_backup_file is unnecessary -- i.e. just keep umask default for backup files. I may try that if I get hold of the testsuite.