openSUSE/trollolo

Missing check for true in unit test.

Closed this issue ยท 2 comments

I think there should be .to be true in lines 20 & 21 expect statements because now the test would pass in any scenario. ๐Ÿ˜„

it 'fetches burndown data from board-list' do
full_board_mock
dir = given_directory
@cli.options = {'board-list' => 'spec/data/board-list.yaml',
'output' => dir}
@cli.burndowns
expect(File.exist?(File.join(dir, 'orange/burndown-data-01.yaml')))
expect(File.exist?(File.join(dir, 'blue/burndown-data-01.yaml')))
end

Ana06 commented

If a test is wrong, you can directly open a PR to fix it, you don't need to open an issue. If it is wrong it has to be be fixed and there is no discussion, so we don't need an issue. ๐Ÿ˜‰

I am working on this.