openaddresses/pyesridump

Last feature in feature collection has extraneous comma

Closed this issue · 7 comments

skorasaurus commented

Thank you for making this Ian.

The last feature obtained contains an extraneous comma which breaks most parsers and validators.

See as an example. https://github.com/opencleveland/clecrime/commit/9d3550152589be253584cea95dd2654d4119df22

iandees commented

Hmm, the best thing to do is probably to install https://github.com/openaddresses/machine:

git clone https://github.com/openaddresses/machine
cd machine
python setup.py install

...and then run openaddr-esri2geojson <esri_url> <output_geojson_filename>

I've been keeping the ESRI-related stuff up to date in machine and not here. I should probably pull it out into this repo and then use this module in machine. Until then, the above will have to work.

fgregg commented

@iandees I was just going to ask if we could get this on pip. Would you like some help

  1. extracting the esri stuff from machine to this repo
  2. getting this repo on pypi
  3. having openaddress/machine depend on an esri-dump package?
fgregg commented

Actually, it doesn't look like the openaddr-esri2geojson has the same subdivision strategy. Instead it looks like it tries to enumerate all the object ids and paginate through them (actually it tries some other things first).

Unfortunately, that depends upon the server supporting the ReturnIdsOnly argument, which was added in ArcGIS REST Server v.10.

The subdivide method used in this repo will work with older versions. Why is the subdivide method not in openaddr-esri2geojson?

iandees commented

@fgregg Good timing! We were actually just thinking about extracting the esri2geojson bits from machine and making a separate module.

I'm planning on starting on it tomorrow morning. If I run out of time or something I'll ping you and take you up on your offer for help!

fgregg commented

I actually had some time today. Let me push up where I got.

On Sat, Aug 13, 2016 at 9:51 PM Ian Dees notifications@github.com wrote:

@fgregg https://github.com/fgregg Good timing! We were actually just
thinking about extracting the esri2geojson bits from machine and making a
separate module.

I'm planning on starting on it tomorrow morning. If I run out of time or
something I'll ping you and take you up on your offer for help!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgxbcuGsLSE0uOzZmq6kf1XPraC5Jo6ks5qfoK-gaJpZM4GOtlw
.

iandees commented

The extraneous comma has been destroyed!

  • 👍1