openai/retro

v0.8.0 build fails on windows: "ld returned 1 exit status"

Silver-Volt4 opened this issue · 2 comments

Silver-Volt4 commented

Issue summary

Good evening (or morning, depends where you live). I tried building this library from source after a friend told me the pypi versions are hacked and contain viruses. (I don't really believe that, but I wanted to be safe). I followed the build steps, installed msys2 64, git, cmake, and then gcc with pacman. Near the end (crash) of the build, it spits out a bunch of "multiple definition" errors and ultimately stops with "ld returned 1 exit status". Being a dummy around C, I didn't understand much. Am I doing something wrong?

System information

  • [Operating system] Windows 10
  • [Python version] 3.8.7
  • [Gym Retro version] 0.8.0

Full error attached.
log.txt

endrift commented

You'll need to apply #213 manually. It's already been fixed in master, but your local version is I guess older than master. Check the "files changed" section to see what changes need to be made.

Silver-Volt4 commented

Thanks, that helped.

edited: I resolved whatever was happening before and deleted the extra text.