openairplay/airplay2-receiver

Why the over-read for RTP?

Closed this issue · 0 comments

systemcrash commented

Here there is an over-read:

airplay2-receiver/ap2/connections/audio.py

Line 47 in d28733e

self.sequence_no = struct.unpack('>I', b'\0' + data[1:4])[0]

Yet here we read only 2 bytes - was there some particular design decision here?

airplay2-receiver/ap2/connections/audio.py

Line 39 in d28733e

self.sequence_no = struct.unpack(">H", data[2:4])[0]

Do you just want the Int value to be 4 bytes instead of 2?