openaps/AndroidAPSdocs

Untranslated admonition does not show at all on live page

Closed this issue · 5 comments

I have noticed that when translation are missing for admonition or other blocks with specific classes, these blocks do not show at all in the live doc page. This seems like a safety issue, because important information are not shown, even in english.

Ex : In Preferences page, under NS v3, we have this admonition : https://androidaps.readthedocs.io/en/latest/Configuration/Preferences.html#nsclientv3
image

In French page, it does not show at all : https://androidaps.readthedocs.io/fr/latest/Configuration/Preferences.html#nsclientv3
image

This is a single example, but I have seen this repeatedly on other pages.

We're addressing issues with Crowdin propagation now. Stay tuned.

Yes. Where the admonition class is set like that in EN:

:::{admonition} V3 data uploaders
:class: warning
When using NSClientV3, all uploaders must be using the API V3. Since most are not compatible yet, this means **you must let AAPS upload all data** (BG, treatments, ...) to Nightscout and disable all other uploaders if they're not V3 compliant.  
:::

Crowdin forgets a line feed and the parser fails understanding the unknown class name

:::{admonition} V3 data uploaders
:class: warning When using NSClientV3, all uploaders must be using the API V3. Since most are not compatible yet, this means **you must let AAPS upload all data** (BG, treatments, ...) to Nightscout and disable all other uploaders if they're not V3 compliant.  
:::

Got it. That's badly converted from doc migration. myST adminitions recommendations are:
It is advised to use admonitions with the colon_fence extension, which signify that the content of the block is also MyST Markdown.
Will fix that (might take some time to catch them all)

Should be fixed with 9689da2
@emilisev please let me know

Not sure if it's all good, with crowdin. Or maybe a side effect. In preparing.md, at the very bottom, in the original file, we have :
image

But in crowdin, the "Google Play Protect potential Issue" string does not show anymore for translation :
image