openatv/enigma2

Skin Selection - doesn't fallaback to setup

Closed this issue · 3 comments

kiddac commented

Since you have changed the name of this. It no longer falls back to setup screen, breaking peoples skins.
Yet if I create the screen, but miss out mandatory items it does fallback to setup screen,
Also remove all the code for mandatory fields. Nothing is mandatory, its up to the skinner what elements they put in skins.
We just end up putting in a load of junk code that say position="0,0" size="0,0".
And if your code breaks because you think its mandatory then you need to fix your code. Not break other peoples work

jbleyel commented

If you do not have "SkinSelection" in your skin you get it from the default skin.

	<screen name="SkinSelection" position="center,center" size="560,600">
		<panel name="Setup"/>
		<widget name="preview" position="117,0" size="280,210" alphatest="on" zPosition="0"/>
	</screen>

This screen looks not good and should be fixed.

jbleyel commented

The problem is that this panel -> <panel name="Setup"/> comes from your skin.
We may need to do that differently.