Incomplete code - config_telephone_required

Question

Incomplete code - config_telephone_required

condor2 opened this issue 2 years ago · 4 comments

Code in setting conteroller

https://github.com/opencart/opencart-3/blob/main/upload/admin/controller/setting/setting.php#L258-L262

Missing from twig
https://github.com/opencart/opencart-3/blob/main/upload/admin/view/template/setting/setting.twig

But is added in customer_form
https://github.com/opencart/opencart-3/blob/main/upload/admin/view/template/customer/customer_form.twig#L101

Answer 1 · 2022-12-21T23:50:30.000Z

Yeah, ok. Something doesn't fit right here. I'll take a look at it.

Answer 2 · 2022-12-22T00:19:48.000Z

Should be fixed now.

Answer 3 · 2022-12-22T12:02:56.000Z

It is not specifically about the telephone_required field as per your title, but since it is still about the telephone field itself, I'll reopen it.

Answer 4 · 2022-12-22T23:19:13.000Z

We can only assume that since you have decided to remove your post that the change you suggested is no longer necessary. Therefore, this commit will now be closed.