openconfig/public

Missing link metric in ospfv2 summary-lsa model

zlei-arista opened this issue · 2 comments

Hi all,

I have a question regarding the model for OSPFv2 Summary LSA.
Looking at the model for it:

+--ro summary-lsa
|  +--ro state
|  |  +--ro network-mask?   uint8 
|  +--ro types-of-service
|     +--ro type-of-service* [tos]
|        +--ro tos      -> ../state/tos
|        +--ro state
|           +--ro tos?      uint8 
|           +--ro metric?   oc-ospf-types:ospf-metric

There isn't any field explicitly for the link metric. The only metric field here is under TOS.

For reference, as-external-lsa made an explicit indication of link metric apart from the TOS-metric field:

+--ro as-external-lsa
|  +--ro state
|  |  +--ro mask?                 uint8
|  |  +--ro metric-type?          enumeration
|  |  +--ro metric?               oc-ospf-types:ospf-metric                 <<<
|  |  +--ro forwarding-address?   inet:ipv4-address-no-zone
|  |  +--ro external-route-tag?   uint32
|  +--ro types-of-service
|     +--ro type-of-service* [tos]
|        +--ro tos      -> ../state/tos
|        +--ro state
|           +--ro forwarding-address?   inet:ipv4-address-no-zone
|           +--ro external-route-tag?   uint32
|           +--ro tos?                  uint8
|           +--ro metric?               oc-ospf-types:ospf-metric

Is summary-lsa missing a field for the link metric? Or is the link metric expected to be under TOS-metric with the TOS value being 0?

Thanks in advance!

dplore commented

I think it is missing. added #916 to address. Please review

Thanks for following up with the fix!