Enforce LGTMs with automated tool

Question

Enforce LGTMs with automated tool

caniszczyk opened this issue 9 years ago · 3 comments

I'm thinking of using PullApprove to enforce the two LGTM sign off

All decisions are pull requests, and the relevant maintainers make decisions by accepting or refusing the pull request. Review and acceptance by anyone is denoted by adding a comment in the pull request: LGTM. However, only currently listed MAINTAINERS are counted towards the required two LGTMs.

Answer 1 · 2016-05-26T17:12:25.000Z

Would you be cool with this @crosbymichael ?

If so, I'd love to try it out on the runtime-spec first :)

https://pullapprove.com/

Answer 2 · 2016-05-27T03:24:02.000Z

I don't like the fact that it's a proprietary tool. Couldn't we just update Gordon to do it for us -- I'd be happy to write the code so we don't have to use a proprietary tool.

Answer 3 · 2016-06-01T17:19:18.000Z

Things are working properly so we will close this.

@cyphar feel free to write something but the tool seems to be working and GitHub itself is proprietary :)