opencredo/terrahelp

func verifyStringSliceFileDefault comment is now out of date

pporada-gl opened this issue · 1 comments

The comment contains links to codegangsta/cli which have both been resolved. It seems like that function isn't needed anymore.
https://github.com/opencredo/terrahelp/blob/master/commands.go#L433-L455

Hi @pporada-gl I believe the function is still required although its purpose has somewhat changed a bit. Although the specific issues cited as part of the initial reason for the workaround function have been fixed (i.e. weird behaviour with defaults) these fixes are currently only available on the as yet unreleased v2 branch, and as far as I can tell, there is still no support for setting a destination yet.

That said however, the function has changed and no longer looks to leverage this functionality directly anymore (this changed in f6cdcf2) so its probably at least worth updating the code to make this more clearer which I will do, thanks!