opendistro-for-elasticsearch/data-prepper

Upgrade Armeria

Opened this issue · 2 comments

kowshikn commented
  1. Version upgrade
  2. "otel.grpc.senrequest" -> The http path of the grpc unframed request is based on grpc protobuf package name + service +operation. In the latest you can have custom name, this would help us in keeping something shorter.
  3. They have grpc health check as well.
wrijeff commented

@kowshikn - upgraded.

Could you please elaborate on points 2 and 3?

  • What would we want to shorten to / what would it get us?
  • For gRPC health check I see line/armeria#3146 is still open 🤔
kowshikn commented

Regards 2,

We will be switching to HTTP 1.1 (by enabling unframed requests), the path for the api will be be ip-address:21890 opentelemetry.proto.collector.trace.v1.TraceService/Export which is not friendly. So I had requested Armeria team to allow custom name. This would mean we can user a path like ip-address:21890/traces/v1`

Regarding 3,

Cool we can keep our health check.

  • 👍1