edX was hardcoded in the cookie banner
Closed this issue · 6 comments
in the cookie banner can we change "edX and its members..." to "{PLATFORM_NAME} and its members..."
Is there a way to set the cookie banner off by default?
@vunguyen-dmt, this was already fixed by #707, where you'll be able to disable the banner via ENABLE_COOKIE_POLICY_BANNER.
However, this will likely only make it into Olive.2. If you want to get it before with Tutor, you can try setting the authn MFE to master and rebuild the image.
Thank you @arbrandes , how about changing the text "edX" to PLATFORM_NAME?
I should've reported this issue in cookie banner repo but I couldn't find the issue tab there.
@zainab-amir, what do you think? Would the suggested PLATFORM_NAME change be acceptable?
@vunguyen-dmt, would you be able to submit a PR to implement this?
Unfortunately, I'm not familiar with Openedx frontend architecture, in this case how to load variables from config or implement multi-languages.
Examine the source code I think this file should be changed.
And the variable linkOpen href should be changed to {LMS_HOST}/privacy or privacy link variable if there is one, rather than "https://edx.org/es/edx-privacy-policy"
Another problem is I didn't see i18n was taken into account.
Hope this helps!
@arbrandes I tried creating a PR for this but the cookie banner was not created with openedX in mind. Even if I update the string, the whole architecture is edX dependent. This is the reason I went with the flag option (ENABLE_COOKIE_POLICY_BANNER) where the cookie banner is disabled by default.
Alright. I guess we can close this, then. Thanks @zainab-amir!