openembedded/meta-openembedded

Question: `python3-twisted` on Kirkstone is missing two runtime dependencies

Closed this issue · 3 comments

gudnimg commented

I noticed when upgrading a project to Kirkstone that Twisted 22.2.0 is missing two runtime dependencies which were later added with these following commits, but haven't been backported:

I currently have a bbappend file in my project to resolve this, but it would be nice to fix the Kirkstone LTS branch.

Adding python3-typing-extensions and python3-asyncio to RDEPENDS:${PN}-core should resolve the issue. Minimum requirement for python3-typing-extensions is 3.6.5, and the OpenEmbedded recipe provides version 3.10.0.0 ✔️

I can try submit a patch for this, but wanted to ask first if a fix like this is considered for merging? This is merely just to fix the recipe upstream.

kraj commented

@gudnimg thanks for report and yes this is a good fix for stable branch, please check with master branch first and if its not fixed there, then propose it for master, if its already fixed in master via another commit then backport that to stable branch, if not backportable, then modify the fix suitable for stable branch

gudnimg commented

if its already fixed in master via another commit then backport that to stable branch

These two commits are in master:

I’m not sure about the best approach to send this via the mailing list (still learning 😀). Do I just cherry pick these on a local kirkstone branch and sign the commits like I would regular commits?

gudnimg commented

On an unrelated note, I would love to backport these two commits as well (they’re from me BTW). They are not critical, but cleaning dependencies is really importart for my application to minimize image size (pip is ~10MB)

But I will focus on twisted first since it causes an actual error. 😊