openfaas/faas

Remove basic-auth-plugin from OpenFaaS CE helm chart

alexellis opened this issue · 1 comments

alexellis commented

Why do you need this?

There's an optimisation in gateway CE 0.26.0 where the basic auth is moved directly into the process, so the plugin can be removed.

This enhancement isn't available for OpenFaaS Pro which can still use the OIDC plugin or basic auth plugin.

Expected Behaviour

When openfaasPro is set to false in the chart then don't deploy the basic-auth-plugin service and deployment.

Current Behaviour

Today, it will be deployed in either case, so it will be there but not used.

Steps to Reproduce (for bugs)

  1. arkade install openfaas --set openfaasPro=false
  2. kubectl get deploy -n openfaas <- should not show the basic auth plugin as it currently does:
$ kubectl get deploy -n openfaas basic-auth-plugin
NAME                READY   UP-TO-DATE   AVAILABLE   AGE
basic-auth-plugin   1/1     1            1           3h51m

$ kubectl get svc -n openfaas basic-auth-plugin
NAME                TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)    AGE
basic-auth-plugin   ClusterIP   10.96.206.147   <none>        8080/TCP   3h51m
alexellis commented

This has now been done for CE and Pro.