openfaas/golang-http-template

chore: remove unused atomic int

mrwormhole opened this issue · 1 comments

mrwormhole commented

My actions before raising this issue

Why do you need this?

I don't need this, I just realized this value is never been used, I am trying to make sense of it for the last 2 weeks, hopefully, this is not an awkward issue to bother people's time. I remember this variable being used in the past when I started learning faasd (around Go version 1.15 1.16 templates)

Expected Behaviour

The variable is set and it should be used

Current Behaviour

The variable is set but never used

https://github.com/openfaas/golang-http-template/blob/master/template/golang-http/main.go#L74
https://github.com/openfaas/golang-http-template/blob/master/template/golang-middleware/main.go#L72

List All Possible Solutions and Workarounds

the solution is just removing the unused variable

Steps to Reproduce (for bugs)

it is not a bug really.

Your Environment

  • FaaS-CLI version ( Full output from: faas-cli version ):
    0.15.4

  • Docker version docker version (e.g. Docker 17.0.05 ):
    Docker version 20.10.21

  • Are you using Docker Swarm or Kubernetes (FaaS-netes)?
    faasd 0.16.7

  • Operating System and version (e.g. Linux, Windows, MacOS):
    linux

  • Code example or link to GitHub repo or gist to reproduce problem:
    N/A

  • Other diagnostic information / logs from troubleshooting guide
    N/A

Next steps

You may join Slack for community support.