[All SDKs] Remove `ReadAuthorizationModel` call in `BatchCheck`
rhamzeh opened this issue · 3 comments
rhamzeh commented
Some (not all) SDKs call ReadAuthorizationModel, before checks in BatchCheck.
We need to remove that and replace that with better error handling where we exit early in cases of 401s instead of repeatedly calling check unnecessarily
- JS SDK openfga/js-sdk#70
- Go SDK openfga/go-sdk#78 @ewanharris
- .NET SDK
- Python SDK
- in client.py and sync client
- remove
_check_valid_api_connectionfromBatchCheckandWrite(and delete the function) - do not ignore ApiAuthenticationError in https://github.com/openfga/python-sdk/blob/main/openfga_sdk/client/client.py#L596-L599 and https://github.com/openfga/python-sdk/blob/main/openfga_sdk/client/client.py#L413-L414
- remove
- update tests as needed
- in client.py and sync client
- Java SDK
aaguiarz commented
Please let's start by addressing it in the Javascript SDK
ewanharris commented
Closing as all SDKs no longer call this or never did
Reopening as python still needs to be done
evansims commented
Python changes shipping with 0.5.0