openfga/vscode-ext

Conflicts with the Prisma Extension

MPiccinato opened this issue · 5 comments

When using this extension along with the Prisma extension, Prisma syntax highlighting breaks, disabling this extension and it works again. I am unsure if this is an issue with this extension or the Prisma extension, but adding this extension into the mix definitely causes .prisma highlighting to break.

Thanks @MPiccinato, we'll take a look

@MPiccinato Would you mind sharing a screenshot of what the Prisma highlighting looks like when broken?

I should have done that in the first place!

Working
Screenshot 2023-08-10 at 3 04 24 PM

Broken
Screenshot 2023-08-10 at 3 05 19 PM

Cool - thanks for that!

I believe it's our fallback color scheme. When we are targeting any file that isn't .openfga or .fga we fall back to Dark (Visual Studio) for all other file extensions while using OpenFGA Dark theme.

If you change your theme to Dark (Visual Studio) whether or not you're using our plugin, the color scheme looks broken cause there is minimal highlights.

Tried this myself without our extension installed. Below is a comparison, with the extension uninstalled, showing difference between Dark (Visual Studio) and Dark Modern:

image
image

Will bring this to the team, but in the mean time, I suggest using a theme that looks satisfactory with both languages.

@d-jeffery Amazing! Thank you for the explanation and taking a look at it. Got it working now. Cheers!