openfoodfacts/openfoodfacts-ios

Support iOS 9

aleene opened this issue · 6 comments

aleene commented

Summary:

The app does not support IOS 9 when building

Observed behavior:
When building for IOS 9 (project and target!) we get an error message, that the module KingFisher requires at least IOS 10.

Xcode version:
Xcode 10.1 and Swift 4 (needed for KIngFisher version 5)

Screenshots:
screen shot 2019-01-20 at 10 28 35

aleene commented

I contacted the developer of KingFisher. onevcat/Kingfisher#1093

philippeauriach commented

I did a quick tour of our libs, and KingFisher is not the only lib having iOS 10 min :

  • XLPagerTabStrip: 9.3
  • KingFisher: 10.0
  • NotificationBanner: 10.0
  • FloatingPanel: 10.0
  • IBLocalizable: 10.0
aleene commented

Will be a lot of work for a small market.

teolemon commented

@philippeauriach @aleene I believe we can call it quits on ios 9 ?

  • 👍2
clarissaj commented

@teolemon should this issue be closed? I imagine supporting iOS 9 is no longer reasonable given iOS 16 just released last week!

teolemon commented

@clarissaj you're quite right 👍 closing