openfoodfacts/openfoodfacts-server

Folksonomy Engine loads CSS and a font from CDNs

hangy opened this issue · 0 comments

hangy commented

@import url("https://ajax.googleapis.com/ajax/libs/jqueryui/1.11.4/themes/redmond/jquery-ui.css");
@import url("https://rawgit.com/free-jqgrid/jqGrid/master/css/ui.jqgrid.css");
@import url("https://netdna.bootstrapcdn.com/font-awesome/4.4.0/css/font-awesome.min.css");

image

For ProductOpener itself, we usually try to reduce the dependency on 3rd party CDNs. folksonomy.js does the opposite by loading three files from three different CDNs.

  1. jQuery UI is already bundled with ProductOpener
  2. FontAwesome could be revisited, because ProductOpener now mostly seems to use Material Icons since the redesign
  3. Bundle jqGrid, or replace it (if there's feature parity) with other grid already bundled?

Code pointers

You can find some code pointers here. If some are missing, feel free to add them yourself in this file, or to ask them.

Part of