build issue on android-x86
Opened this issue · 27 comments
Recenlty I built android*x86 without gapps with kernel 4.15 gapps without any nowissue. But, i am building new android-x86 with gapps and facing this issue.
native: #07 pc 000000000000d748 /home/harkamanshivakoti/android-x86/out/host/linux-x86/bin/dex2oatd (???)
/bin/bash: line 1: 31136 Aborted (core dumped) ( ANDROID_LOG_TAGS="*:e" out/host/linux-x86/bin/dex2
oatd --runtime-arg -Xms64m --runtime-arg -Xmx512m --runtime-arg -classpath --runtime-arg "&" --boot-image=out/targe
t/product/x86/dex_bootjars/system/framework/boot.art --dex-file= --dex-location=/system/priv-app/Phonesky/Phonesky.
apk --oat-file=out/target/product/x86/obj/APPS/Phonesky_intermediates/oat/x86/package.odex --android-root=out/targe
t/product/x86/system --instruction-set=x86 --instruction-set-variant=x86 --instruction-set-features=default --inclu
de-patch-information --runtime-arg -Xnorelocate --no-generate-debug-info --abort-on-hard-verifier-error --no-inline
-from=core-oj.jar --compile-pic )
[ 78% 30592/38775] target Package: Contacts (out/target/product/x86/obj/APPS/Contacts_intermediates/package.apk)
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
Warning: AndroidManifest.xml already defines versionCode (in http://schemas.android.com/apk/res/android); using exi
sting value in manifest.
Warning: AndroidManifest.xml already defines versionName (in http://schemas.android.com/apk/res/android); using exi
sting value in manifest.
Warning: AndroidManifest.xml already defines minSdkVersion (in http://schemas.android.com/apk/res/android); using e
xisting value in manifest.
Warning: AndroidManifest.xml already defines targetSdkVersion (in http://schemas.android.com/apk/res/android); usin
g existing value in manifest.
nothing matches overlay file view_pager_tab_background.xml, for flavor v21
[ 78% 30592/38775] Building with Jack: out/target/common/obj/APPS/Dialer_intermediates/with-local/classes.dex
ninja: build stopped: subcommand failed.
build/core/ninja.mk:148: recipe for target 'ninja_wrapper' failed
make: *** [ninja_wrapper] Error 1
and
nothing matches overlay file view_pager_tab_background.xml, for flavor v21
[ 78% 30614/38776] target Prebuilt: Ph...PS/Phonesky_intermediates/package.apk)
FAILED: /bin/bash -c "(out/host/linux-x86/bin/acp -fp out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk ) && (if (zipinfo out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk 'lib/*.so' 2>/dev/null | grep -v ' stor ' >/dev/null) ; then rm -rf out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs && mkdir out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs; unzip out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk 'lib/*.so' -d out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs && zip -d out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk 'lib/*.so' && ( cd out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs && find lib -type f | sort | zip -D -X -0 ../package.apk -@ ) && rm -rf out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs; fi ) && (if ! out/host/linux-x86/bin/zipalign -c -p 4 out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk >/dev/null ; then mv out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk.unaligned; out/host/linux-x86/bin/zipalign -f -p 4 out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk.unaligned out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk.aligned; mv out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk.aligned
```out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk; fi )"
acp: missing destination file
[ 78% 30614/38776] Building with Jack:...g_intermediates/with-local/classes.dex
ninja: build stopped: subcommand failed.
build/core/ninja.mk:148: recipe for target 'ninja_wrapper' failed
make: *** [ninja_wrapper] Error 1
make: Leaving directory '/media/harkman/7915d850-4613-4b73-8c5c-c68726b11a8d/android-x86'
#### make failed to build some targets (02:45:13 (hh:mm:ss)) ####
I am not sure this is gaps issue or some other type of issue, but i can build without gapps, but I want and wish to build with gapps.
#OpenGAPPS
GAPPS_VARIANT := pico
GAPPS_FORCE_BROWSER_OVERRIDES := true
GAPPS_EXCLUDED_PACKAGES := FaceLock \
AndroidPlatformServices \
PrebuiltGmsCoreInstantApps \
#OpenGAPPS
$(call inherit-product, vendor/opengapps/build/opengapps-packages.mk)
<!-- BEGIN OPENGAPPS-X86 -->
<remote name="opengapps" fetch="https://github.com/opengapps/" />
<project path="vendor/opengapps/build" name="aosp_build" revision="master" remote="opengapps" />
<project path="vendor/opengapps/sources/all" name="all" clone-depth="1" revision="master" remote="opengapps" />
<project path="vendor/opengapps/sources/x86" name="x86" clone-depth="1" revision="master" remote="opengapps" />
<project path="vendor/opengapps/sources/x86_64" name="x86_64" clone-depth="1" revision="master" remote="opengapps" />
<!-- END OPENGAPPS-X86 -->
Please help, thank you
Today I build without/ exclude Phonesky
in device.mk. It build ok. tested. But, no play store.
then i build again include Phonesky. Then i get error again
[ 82% 30226/36633] target Prebuilt: Phonesky (out/target...product/x86/obj/APPS/Phonesky_intermediates/package.apk)
FAILED: /bin/bash -c "(out/host/linux-x86/bin/acp -fp out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk ) && (if (zipinfo out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk 'lib/*.so' 2>/dev/null | grep -v ' stor ' >/dev/null) ; then rm -rf out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs && mkdir out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs; unzip out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk 'lib/*.so' -d out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs && zip -d out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk 'lib/*.so' && ( cd out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs && find lib -type f | sort | zip -D -X -0 ../package.apk -@ ) && rm -rf out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs; fi ) && (if ! out/host/linux-x86/bin/zipalign -c -p 4 out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk >/dev/null ; then mv out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk.unaligned; out/host/linux-x86/bin/zipalign -f -p 4 out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk.unaligned out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk.aligned; mv out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk.aligned out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk; fi )"
acp: missing destination file
[ 82% 30226/36633] target Package: Dialer (out/target/product/x86/obj/APPS/Dialer_intermediates/package.apk)
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
Warning: AndroidManifest.xml already defines versionCode (in http://schemas.android.com/apk/res/android); using existing value in manifest.
Warning: AndroidManifest.xml already defines versionName (in http://schemas.android.com/apk/res/android); using existing value in manifest.
Warning: AndroidManifest.xml already defines minSdkVersion (in http://schemas.android.com/apk/res/android); using existing value in manifest.
Warning: AndroidManifest.xml already defines targetSdkVersion (in http://schemas.android.com/apk/res/android); using existing value in manifest.
ninja: build stopped: subcommand failed.
build/core/ninja.mk:148: recipe for target 'ninja_wrapper' failed
make: *** [ninja_wrapper] Error 1
make: Leaving directory '/home/harkamanshivakoti/android-x86'
#### make failed to build some targets (01:07:19 (hh:mm:ss)) ####
again to day so eone told me to do this but still build fail. I did LOCAL_DEX_PREOPT := false , but still error or fail. i don't know how to fix.
Warning: AndroidManifest.xml already defines versionCode (in http://schemas.android.com/apk/res/android); using existing value in manifest.
Warning: AndroidManifest.xml already defines versionName (in http://schemas.android.com/apk/res/android); using existing value in manifest.
Warning: AndroidManifest.xml already defines minSdkVersion (in http://schemas.android.com/apk/res/android); using existing value in manifest.
Warning: AndroidManifest.xml already defines targetSdkVersion (in http://schemas.android.com/apk/res/android); using existing value in manifest.
[ 82% 30208/36632] target R.java/Manifest.java: setup-wi...VA_LIBRARIES/setup-wizard-lib_intermediates/src/R.stamp)
Warning: AndroidManifest.xml already defines minSdkVersion (in http://schemas.android.com/apk/res/android); using existing value in manifest.
Warning: AndroidManifest.xml already defines targetSdkVersion (in http://schemas.android.com/apk/res/android); using existing value in manifest.
[ 82% 30221/36632] target R.java/Manifest.java: MediaPro...common/obj/APPS/MediaProvider_intermediates/src/R.stamp)
Warning: AndroidManifest.xml already defines versionCode (in http://schemas.android.com/apk/res/android); using existing value in manifest.
[ 82% 30227/36632] target Package: InputDevices (out/tar...uct/x86/obj/APPS/InputDevices_intermediates/package.apk)
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
[ 82% 30229/36632] target Prebuilt: Phonesky (out/target...product/x86/obj/APPS/Phonesky_intermediates/package.apk)
FAILED: /bin/bash -c "(out/host/linux-x86/bin/acp -fp out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk ) && (if (zipinfo out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk 'lib/*.so' 2>/dev/null | grep -v ' stor ' >/dev/null) ; then rm -rf out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs && mkdir out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs; unzip out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk 'lib/*.so' -d out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs && zip -d out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk 'lib/*.so' && ( cd out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs && find lib -type f | sort | zip -D -X -0 ../package.apk -@ ) && rm -rf out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs; fi ) && (if ! out/host/linux-x86/bin/zipalign -c -p 4 out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk >/dev/null ; then mv out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk.unaligned; out/host/linux-x86/bin/zipalign -f -p 4 out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk.unaligned out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk.aligned; mv out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk.aligned out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk; fi )"
acp: missing destination file
[ 82% 30229/36632] build out/target/product/x86/obj/APPS/SetupWizard_intermediates/oat/x86/package.odex
ninja: build stopped: subcommand failed.
build/core/ninja.mk:148: recipe for target 'ninja_wrapper' failed
make: *** [ninja_wrapper] Error 1
make: Leaving directory '/home/harkamanshivakoti/android-x86'
I don't think opengapps has an "x86" or "x86_64" version of Phonesky (i.e. "com.android.vending"), which probably explains the "acp" error message.
However, there are apks for "com.android.vending.leanback" in the "x86" and "x86_64" projects. You could try installing one of those.
I think you will have to create a new build module for it. It should look something like this:
# vendor/opengapps/build/modules/GooglePlayStoreLeanback/Android.mk
LOCAL_PATH := .
include $(CLEAR_VARS)
include $(GAPPS_CLEAR_VARS)
LOCAL_MODULE := GooglePlayStoreLeanback
LOCAL_PACKAGE_NAME := com.android.vending.leanback
LOCAL_PRIVILEGED_MODULE := true
include $(BUILD_GAPPS_PREBUILT_APK)
please look at this screen.
I cannot find GooglePlayStoreLeanback folder. Do i need to create one?
https://imgur.com/a/7v9em
Do i need to exclude phonesky? I could see it on my harddrive and cloud. How can I just download or sync only for x86 and x86_64. It use to ok a few weeks ago i could build. It shows error recently.
Is that possible to fix on source. so I can re-sync and build and we don't need to create every time (maybe there are some other people may face this issue.)
<remote name="opengapps" fetch="https://github.com/opengapps/" />
<project path="vendor/opengapps/build" name="aosp_build" revision="master" remote="opengapps" />
<project path="vendor/opengapps/sources/all" name="all" clone-depth="1" revision="master" remote="opengapps" />
<project path="vendor/opengapps/sources/x86" name="x86" clone-depth="1" revision="master" remote="opengapps" />
<project path="vendor/opengapps/sources/x86_64" name="x86_64" clone-depth="1" revision="master" remote="opengapps" />
Do I need to add this line. Maybe this line bring all the apks?
vendor/opengapps/sources/all" name="all" clone-depth="1" revision="master" remote="opengapps"
#OpenGAPPS
$(call inherit-product, vendor/opengapps/build/opengapps-packages.mk)
#OpenGAPPS
GAPPS_VARIANT := pico
GAPPS_FORCE_BROWSER_OVERRIDES := true
Is this correct?
You are going to have to experiment on your own a bit. I don't have all the answers :-) Note that I've never built android-x86.
I cannot find GooglePlayStoreLeanback folder. Do i need to create one?
Yes, you will need to create a new folder for the new build module: vendor/opengapps/build/modules/GooglePlayStoreLeanback/Android.mk
.
Do i need to exclude phonesky?
Yes.
@jamuir It did not help. I did exclude phonesky and add
vendor/opengapps/build/modules/GooglePlayStoreLeanback/Android.mk.
as you said. build ok, but no playstore.
@jamuir
i tested again, with fresh new folder and sync or downloaded android x86 source code form osdn +opengapps. But, still same issue.
[ 83% 30546/36635] target Prebuilt: Phonesky (out/target...product/x86/obj/APPS/Phonesky_intermediates/package.apk)
FAILED: /bin/bash -c "(out/host/linux-x86/bin/acp -fp out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk ) && (if (zipinfo out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk 'lib/*.so' 2>/dev/null | grep -v ' stor ' >/dev/null) ; then rm -rf out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs && mkdir out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs; unzip out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk 'lib/*.so' -d out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs && zip -d out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk 'lib/*.so' && ( cd out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs && find lib -type f | sort | zip -D -X -0 ../package.apk -@ ) && rm -rf out/target/product/x86/obj/APPS/Phonesky_intermediates/uncompressedlibs; fi ) && (if ! out/host/linux-x86/bin/zipalign -c -p 4 out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk >/dev/null ; then mv out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk.unaligned; out/host/linux-x86/bin/zipalign -f -p 4 out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk.unaligned out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk.aligned; mv out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk.aligned out/target/product/x86/obj/APPS/Phonesky_intermediates/package.apk; fi )"
acp: missing destination file
[ 83% 30546/36635] build out/target/product/x86/obj/APPS/SetupWizard_intermediates/oat/x86/package.odex
ninja: build stopped: subcommand failed.
build/core/ninja.mk:148: recipe for target 'ninja_wrapper' failed
make: *** [ninja_wrapper] Error 1
make: Leaving directory '/home/harkamanshivakoti/android-x86'
It did not help. I did exclude phonesky and add
vendor/opengapps/build/modules/GooglePlayStoreLeanback/Android.mk.
After you define a new module, you need to explicitly add it to your build.
You should have something like this in your device.mk file:
GAPPS_EXCLUDED_PACKAGES += Phonesky
PRODUCT_PACKAGES += GooglePlayStoreLeanback
@jamuir
I did as you said, play store installed, but it is not the x86 version. when i click on play store, it says "This version of the app isn't compatible with your device . To fix this problem, go to settings and uninstall update for Google play store app." The version is 8.7.08-xhdpi (8) (PR) 180622504.
After a few min, the app get auto update and it starts working. The apps updated to Google Play Store 9.0.15-all [0] [PR] 186388994 finally it is working.
play store installed, but it is not the x86 version.
opengapps provides two apks for com.android.vending.leanback. One is in the x86 project and the other is in the x86_64 project. You installed one of those. If you check in those projects, you can see that those apks use sdk version 21.
When android says "This version of the app isn't compatible with your device", I think it is just checking the sdk version of the apk and then forcing you to upgrade to a new apk that matches your platform.
You mentioned previously that other people might be hitting this same build issue (btw, is this an oreo only issue?). Perhaps you could help them by contributing a PR to opengapps with your changes.
I built nougat x86. I checked apk on setting and app, there it shows 8.7.08-xhdpi (8) (PR) 180622504. (8) is for android-tv? I faced same issue also on oreox86. Since oreo-x86 is not stable, I don't use them. only nougat x86.
"Google Play Store 9.1.24
App Notes:
[0] - For all devices.
[5] - For Android Wear devices
[8] - For Android TV devices."
Info: https://www.apkmirror.com/apk/google-inc/google-play-store/google-play-store-9-1-24-release/
PLease look at these apk: they are
[5] - For Android Wear devices
[8] - For Android TV devices.
https://github.com/opengapps/x86/tree/master/priv-app/com.android.vending.leanback/21/320
https://github.com/opengapps/x86/tree/master/priv-app/com.android.vending.watch/24/240-320-480
https://github.com/opengapps/x86_64/tree/master/priv-app/com.android.vending.leanback/21/320
https://github.com/opengapps/x86_64/tree/master/priv-app/com.android.vending.watch/24/240-320-480
I am happy that it solved my issue. one or other way. I don't know how to "PR". I wish it can help other and for me as well, then we don't need to make mkdir GooglePlayStoreLeanback folder and make Android.mk file. PLease guide me how to make "PR".
PR stands for "pull request".
Start by forking the project https://github.com/opengapps/aosp_build into your own github account.
Make whatever fixes you like and then push them up to your forked copy.
Then use the button "New pull request" to open a pull request so your changes can be considered for inclusion in the main project.
And I have the same issue.
com.android.vending for x86 was there until Feb, 27th. Deleted in this commit: opengapps/x86@09c44ee
@NicholasBuse Please, could you explain why?
commit message mentions "arm", but it's in x86 repo...
Downloading com.android.vending apk from pre-09c44ee2c62b624256d245859504096e492db983 and then building seems to work
@amezin : thanks for pointing out that change in x86!
It seems likely that the apk was removed by mistake.
@jamuir And I remember that it's not the first time. Some time ago when I tried opengapps for the first time, there was the same problem. Then com.android.vending suddenly appeared in x86 repo. And now it disappeared again.
Another thing related to this issue, I think:
$ unzip -l open_gapps-x86-6.0-stock-20180308.zip
...
11837470 01-01-2009 00:00 Core/vending-arm.tar.lz
...
Is it actually intended?
My guess it that is it not intended. It doesn't make sense to put an arm apk in an archive for x86.
There must be a bug in one of the opengapps scripts:
It's not a bug, it's just incorrect commit. Phonesky was removed for all x86 platforms, and kept for ARM only. If we need only one APK for both platforms, than it should be moved to all source, not ARM.
@Ganster41 but latest apk contains native libraries for arm only:
110344 2009-01-01 00:00 lib/armeabi-v7a/libbrotli.so
2681060 2009-01-01 00:00 lib/armeabi-v7a/libcronet.66.0.3356.0.so
170496 2009-01-01 00:00 lib/armeabi-v7a/libtensorflowlite_jni.so
It may work on x86 with Houdini, but what about x86 without houdini and other platforms?
@amezin that's why I don't completely understand what is the purpose of that changes.
Have anyone tried to use latest arm apk on x86 platform? It has some strange libs folder, which contains native libraries for both platforms. May be it's the new magic from Google?)
The play store has never had an x86 variant. They have always been a single multi-arch APK. Google removed x86 and x86_64 from the current APK. AFAIK we have always counted on houdini for arm-x86 support...
@NicholasBuse if it's exactly the same apk for all platforms, then +1 on moving it to "all"
All is typically used for no-arch APKs (no processor dependent binaries)
If it's the same APK for all arches - I see no difference from noarch. If we define "no-arch" as "for all architectures" - put the APK to "all", problem solved. Copying the apk to all arch-specific repos (as it was before) will work too, though for me it makes no sense.
Leaving the APK only in "arm" causes problems for us - people who use aosp_build. We'll have to download extra arch-specific repository (a big one) just to get one APK (and also aosp_build scripts won't pick up the APK from "arm" for x86, AFAIK, so extra changes will be necessary).
There doesn't seem to be any harm in storing multi-arch apks in "all" (along with no-arch).
I agree that forcing devs to sync "arm" and "arm64" when they just want to build for x86 is inconvenient.
Agreed. @NicholasBuse can you consider changing the scripts?
quoting amezin:
(and also aosp_build scripts won't pick up the APK from "arm" for x86, AFAIK, so extra changes will be necessary).
That's right. The build system used by aosp_build currently searches for apks in the directories/projects all
, $(TARGET_ARCH)
and $(TARGET_2ND_ARCH)
(in that order). See here: