opengapps/aosp_build

Android 9 build contains opengapps-permissions-q.xml and opengapps-permissions.xml

Closed this issue · 5 comments

nexus511 commented

If integrated into an AOSP build, both files are currently added to the system.

As there are entries that make Android 9 systems bootloop in the opengapps-permissions-q.xml, this should not be added to the system for API-levels before 29.

I guess that this is the same for Android 10 as well, as there is no distinction and the file is added in opengapps-files.mk by gapps_etc_files := $(call gapps-copy-to-system,all,etc).

I removed the file manually from my device. This allowed booting into the android system properly. I will work on a patch to remove it from the build.

MarijnS95 commented

See #247

EDIT: @nezorflame Tagging you since you seem to be the only active opengapps contributor also monitoring aosp_build: Can you request any of the "collaborators" on this project to review and merge outstanding PRs, please?

nexus511 commented

@MarijnS95 That looks exactly like my patch. Than I close this ticket and hope, that it gets merged at some point.

MarijnS95 commented

@nexus511 You might leave this issue open for others to find and as a nudge to collaborators to take a look at it 😉

nexus511 commented

@MarijnS95 Good point. As it has now been merged already, I guess it is still fine to have it closed.

  • 👍1
nezorflame commented

Thanks for merging! I'm out of town for this weekend so I don't have the capability to properly review.