opengeospatial/ogc-geosparql

Concave Hull parameters and algorithms

Closed this issue · 6 comments

A comment from the OGC-NA SubCommittee.

The calculation of a concave hull depends on a number of parameters.

For example, Geotools, GEOS library and PostGIS accept various parameters in their concave hull functions.

Given that a concave hull depends on various parameters and algorithms chosen, please provide some informative text to highlight this, unless of course, a specific Concave Hull has been specified. In that case, the details of which Concave Hull has been selected should be documented.

Thanks @chris-little for spotting this.

jabhay commented
  • Add informative text to describe that concave hull depends on various parameters and algorithms chosen.
jabhay commented

Hey Paul, preferred wording below:

Various implementers use parameters to calculate a concave hull. As such, two implementations may return different results for the same geometry from their concave hull functions. Implementers should make clear any default values used to calculate a concave hull in their documentation.

...different results from their concave hull functions for the same geometry. would be my preference. ;-)

jabhay commented

Thanks @chris-little , let's go with that @paulc-dstl

Ok @jabhay will do! I spoke to @chris-little this morning (unaware of the chat on here) and we are all in agreement. So I'll make those changes asap and job done.

jabhay commented

Changes made, and PR ready for approval