Several plugin ZIPs using QGIS Plugin CI have duplicated files inside
kannes opened this issue · 9 comments
For some reason I downloaded all QGIS plugins and extracted them. I noticed an issue and it looks like QGIS Plugin CI is a common demoninator. If it is not the cause, sorry! :)
resources.py is included twice in 5 plugins:
- opengisch/qgis-swiss-locator#36
- https://github.com/dsgoficial/DSGToolsOp/issues/36
- dsgoficial/DeepLearningTools#9
- https://forge.chapril.org/linux_alpes/caliec/ (no issue filed because no account)
- https://gitlab.com/Oslandia/qgis/qompligis (no issue filed because no account)
They all seem to use QGIS Plugin CI so I wonder if this is caused by some bug in it or misconfiguration at the plugin CIs?
cc @Guts (for QompliGIS, I think I already spotted this issue for LSCI)
Thanks for investigating this!
For swiss locator (downloaded from the GH repo release asset), I see resources.qrc and resources_rc.py at the root?
Are you saying we should avoid shipping the .qrc file?
No, he means the resources.py file is duplicated in the ZIP : https://github.com/opengisch/qgis-swiss-locator/releases/download/1.4.6/swiss_locator.1.4.6.zip
When it's extracted, one file is deleted by the OS, logical ...
I should add, this causes no issues when installing the plugins via QGIS's plugin installer. I guess it will just overwrite the duplicate.
This is mostly a cosmetic thing but it might be worth fixing for the sake of clean packaging. I only noticed it because I unpacked the ZIPs with standard archive tools.
I guess the issue is when there is already one _rc.py file in the sources, which should not happen normally.
worked as expected
