opengisch/qgis-plugin-ci

Why not Python 3.6?

ismailsunni opened this issue · 9 comments

ismailsunni commented

Hi!
I am curious, why is the minimum python version is 3.7? and will it be hard to make it work with python 3.6?
Thanks :)

*sorry, since it's a question, not a bug report

Gustry commented

I can't remember why.
I remember I got issues. Where do you have 3.6?

Just if you need it : https://hub.docker.com/repository/docker/etrimaille/qgis-plugin-ci

ismailsunni commented

On my Ubuntu 18.04, tried to upgrade to 3.7, but a lot of problems related to apt.

Ah, I also just finished creating Dockerfile for it a few minutes ago :D *very short anyway

Thanks, @Gustry!

Gustry commented

You can try to install on 3.6 in a virtualenv, but some functionalities will fail.

If you use docker with your custom image, you might hit issues about git config (username and email which are required for git stash).

Just showing our gitlab-ci file :

      docker run
      --rm -w /plugin
      -v ${CI_PROJECT_DIR}:/plugin
      -u $(id -u):$(id -g)
      etrimaille/qgis-plugin-ci:1.8.2
      package ${CI_COMMIT_REF_NAME}
      --allow-uncommitted-changes
      --disable-submodule-update
      --plugin-repo-url https://custom.server.url/

I will write a readme.

Gustry commented

Are you fine with my docker image?
Can we close this one or do you plan to port it to 3.6 ?

ismailsunni commented

hi @Gustry , I ended up using a manual way since I got an error when running the push-translation. Because I can't debug it without docker, I gave up :)
I think we can close this one.

Gustry commented

You can't use Travis or GitHub actions?

ismailsunni commented
Gustry commented

@ismailsunni I have fixed the docker image when pushing translations 3liz/docker-qgis-plugin-ci@2de63f8

And in this repo as well 59846e7

ismailsunni commented

Thanks, @Gustry, hopefully, I can find a time to try :)