Workaround causes serial port discovery issues
Opened this issue · 8 comments
The binding currently uses serialPortManager.getIdentifiers() to see if there are any SerialPortIdentifiers.
This workaround was added in #335 by @triller-telekom.
The workaround causes serial port detection issues because the getIdentifiers() method will only return discovered ports.
As a result:
- Undiscovered (non-standard) RXTX ports will not work this way (e.g ports defined in udev rules), the transport adds undiscovered ports to
gnu.io.rxtx.SerialPortsso they can be used without users having to configure this - RFC2217 ports cannot be used because there is no discovery logic for these ports.
We've upgraded nrjavaserial in OH3 so we should retest if this is still an issue.
We should also test if it is fixed with nrjavaserial 5.1.0+ because it contains fixes for hardware that gets removed.
If this is no longer an issue we should remove the workaround by instead detecting that a controller is disconnected by just opening the port and handling any resulting exceptions.
If it is still an issue, we should create an issue for it in the nrjavaserial issue tracker with a reproduction scenario. That way we can fix the root cause and don't need to add such workarounds (causing discovery issues) to other add-ons.
Related to:
The crash/exit can also be reproduced with other USB devices and will probably be resolved when NeuronRobotics/nrjavaserial#180 is fixed.
The workaround can be removed in OH3 because nrjavaserial 5.2.1 no longer exits the JVM in certain scenarios when ports are closed/reopened.
nrjavaserial 5.2.1 no longer exits the JVM
Unfortunately that's not true on a Mac at least.
This issue has been mentioned on openHAB Community. There might be relevant details there:
https://community.openhab.org/t/success-with-sonoff-zigbee-bridge-and-zigbee-binding/104985/81
This issue has been mentioned on openHAB Community. There might be relevant details there:
https://community.openhab.org/t/oh3-zigbee-binding-not-working-with-rfc2217-port/115711/2
It would be good if this can be fixed. Sonoff ZBBridge can be used with zigbee binding, but only with socat because RFC2217 does not work.
Unfortunately that's not true on a Mac at least.
Hopefully your Mac issue will be fixed by NeuronRobotics/nrjavaserial#211