openid/OpenYOLO-Android

Bug: HintRetrieveResult.Builder#setHintFromProto will throw exception for valid failure responses

dxslly opened this issue · 1 comments

Looks like a simple fix:

private Builder setHintFromProto(@Nullable Protobufs.Hint hint) {
        mHint = (hint != null) ? Hint.fromProtobuf(hint) : null;
        return this;
}

This protobuf runtime implementation returns a default implementation for nested messages. The conditional check above needs to be modified to check against this rather than null.

Fixed in 533d5c0