openkruise/rollouts

[Bug] When the last batch of releases is done and in a paused state, the rollback will be considered a new release

machine3 opened this issue · 2 comments

last paused

image

rollback

image

reason:

https://github.com/openkruise/rollouts/blob/v0.3.0/pkg/util/controller_finder.go#L372

RS with zero replices is filtered out here

@machine3 The probability is that the configuration you rolled back this time has some differences from the original v1 configuration.

@zmberg It is because the number of old RS replicas has been reduced to 0, but the rollout is not over yet, so it should be possible to roll back at this time.

Mingzhou knows about this problem, I told him about it on DingDing.