openmainframeproject/cobol-check

Problem with sub calls.

Closed this issue · 9 comments

Hi all,

Small issus but the last push broke le comments on the "call" segments to sub-programms.
Is this wanted ?

Wait... was commenting the sub programms ever a thing ?

Also if there is no MOCK
this line is generated lines.add(" 01 UT-MOCKS-GENERATED.");

this will cause an error because there is no pic attribut to it

quick fix.

List<String> generateWorkingStorageMockCountLines(List<Mock> mocks){

    List<String> lines = new ArrayList<>();
    if (mocks.size() > 0) {
        lines.add("       01  UT-MOCKS-GENERATED.");
        lines.addAll(generateMockCountValues(mocks));
    }
    return lines;
}

Mock calls has yet to be developed. Do you have an example of what it was that broke?
@dakaa16 Can you fix the superfluous 01 element generated, and make sure there is a test for it?

Found the issus to my first question.

When there is no mock the rest of the code is unreachable after INITIALIZE-MOCK

image

So my fix won't work :(

I'll make sure that the code gets generated correctly if there is no mock present.

Hi @samdion1994, the generation of code when no mock is present should be fixed now. Do let me know if this fixes your issue

Hi @samdion1994
Can you confirm that the issue is fixed?
/Rune

Hi @Rune-Christensen & @dakaa16 I will comfirm this week sorry been really busy :) !

Hi @samdion1994
Just a friendly reminder to confirm that the issue is fixed :-)
/Rune

This is good for me now Thanks :)!!!