openpharma/crmPack

Output from `tidy-IncrementsRelativeParts` is sub-optimal

Opened this issue · 1 comments

.DefaultIncrementsRelativeParts() %>% tidy()
An object of class "IncrementsRelativeParts"
Slot "dlt_start":
[1] 0

Slot "clean_start":
[1] 1

Slot "intervals":
[1] 0 2

Slot "increments":
[1] 2 1

> .DefaultIncrementsRelativeParts() %>% tidy()
$dlt_start
# A tibble: 1 × 1
  dlt_start
      <int>
1         0

$clean_start
# A tibble: 1 × 1
  clean_start
        <int>
1           1

$intervals
# A tibble: 2 × 1
  intervals
      <dbl>
1         0
2         2

$increments
# A tibble: 2 × 1
  increments
       <dbl>
1          2
2          1

attr(,"class")
[1] "tbl_IncrementsRelativeParts" "list"      

The intervals and increments tibbles should probably combined, in a manner similar to

.DefaultIncrementsRelative() %>% tidy()
# A tibble: 2 × 3
    min   max increment
  <dbl> <dbl>     <dbl>
1     0    20      1   
2    20   Inf      0.33

If done, knit_print.IncrementsRelativeParts will need to be modified. This will be straightforward.

.. and similarly for IncrementsRelativeDLTCurrent /knit_print.IncrementsRelativeDLTCurrent and IncrementsRelativeDLT /knit_print.IncrementsRelativeDLT.