openpharma/mmrm

Fix documentation error in spatial exponential covariance function

Closed this issue · 3 comments

kkmann commented

I think https://openpharma.github.io/mmrm/latest-tag/articles/covariance.html#spatial-exponential is not correct - it should be rho to the power of d, not -d, right?

The implementation is correct

mmrm/src/covariance.h

Line 134 in c9dd43b

matrix<T> expdist = exp(distance.array() * log(rho));

danielinteractive commented

Could be, @clarkliming what do you think?

clarkliming commented

yes you are right. Thank you for spotting this.

  • 👍1